Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree owner to Neutral for all trees on RA/TD maps #15457

Merged
merged 2 commits into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@reaperrr
Copy link
Contributor

reaperrr commented Aug 3, 2018

Otherwise AI squads will try to attack them and get stuck (because only flame units can damage them).

@reaperrr reaperrr added this to the Next release milestone Aug 3, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Aug 3, 2018

Do we want some kind of lint rule to enforce this?

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Aug 3, 2018

What property would you base such a rule on? I can only imagine such a lintrule working if we add a trait specifically to these kind of actors and the lintrule would then check for the ownership of the actors with that trait.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Aug 3, 2018

add a trait specifically to these kind of actors and the lintrule would then check for the ownership of the actors with that trait.

Yes, exactly. The trait would be added on the base templates, so only needs to be declared a few times.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Aug 3, 2018

In that case, I can get behind that idea.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Aug 3, 2018

It would be even better if we could enforce this (Neutral owner) in the editor as well if the actor has that trait, because forgetting to change the player before placing trees can happen easily and fixing it manually is only really feasible via text editor, which requires unzipping/saving unpackaged, making the whole process a pain.

reaperrr added some commits Aug 3, 2018

Fix tree owner on several RA maps
Owner: Creeps can lead to AI trying to attack trees, so all trees must have Neutral as owner.
Fix tree owner on TD maps
Needs to be Neutral instead of Creeps, to avoid confusing the AI.

@reaperrr reaperrr force-pushed the reaperrr:fix-jungle-law branch from 92b8884 to bd1dec6 Aug 4, 2018

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Aug 4, 2018

Updated, fixed all other maps as well.

The trait + lint check I used to identify them will come in a separate PR.

@GraionDilach
Copy link
Contributor

GraionDilach left a comment

👍

@reaperrr reaperrr changed the title Fix tree owner to Neutral for all trees on Jungle Law Fix tree owner to Neutral for all trees on RA/TD maps Aug 4, 2018

@pchote

pchote approved these changes Aug 4, 2018

@pchote pchote merged commit e179a95 into OpenRA:bleed Aug 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote

This comment has been minimized.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Aug 4, 2018

Sorry, but this was merged a tad too early, looks like something went wrong while updating/saving the TD maps. I'll file a follow-up shortly.

@reaperrr reaperrr deleted the reaperrr:fix-jungle-law branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.