Fix tree owner to Neutral for all trees on RA/TD maps

[reaperrr]

Otherwise AI squads will try to attack them and get stuck (because only flame units can damage them).

[pchote]

Do we want some kind of lint rule to enforce this?

[GraionDilach]

What property would you base such a rule on? I can only imagine such a lintrule working if we add a trait specifically to these kind of actors and the lintrule would then check for the ownership of the actors with that trait.

[pchote]

add a trait specifically to these kind of actors and the lintrule would then check for the ownership of the actors with that trait.

Yes, exactly. The trait would be added on the base templates, so only needs to be declared a few times.

[GraionDilach]

In that case, I can get behind that idea.

[reaperrr]

It would be even better if we could enforce this (Neutral owner) in the editor as well if the actor has that trait, because forgetting to change the player before placing trees can happen easily and fixing it manually is only really feasible via text editor, which requires unzipping/saving unpackaged, making the whole process a pain.

[reaperrr]

Updated, fixed all other maps as well.

The trait + lint check I used to identify them will come in a separate PR.

[GraionDilach]

👍

[pchote]

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/5fd608f6cb1470ef5b51d335bbb4e8a08f14b2cd

Picked to prep: ced9ff2, 9d0d25e

[reaperrr]

Sorry, but this was merged a tad too early, looks like something went wrong while updating/saving the TD maps. I'll file a follow-up shortly.