Some CrateSpawner related changes

[MustaphaTR]

First commit fixes the small issue with owners i noted at #15586.

Second commit adds an actor init to pass which CrateSpawner trait spawned the crate, so multipile CrateSpawner traits can have their max-min values separetly calculated. I never noticed if it was ever a problem, nor tested it. But if that was actually the case, this should fix preplaced and Supply Truck (and Scrap Crates for Generals Alpha) crates intervene with CrateSpawner trait.

Third commit makes the trait conditional. While not much useful under World actor. I use CrateSpawner under Player actor and i used conditions so i can add additional crates per player in No Bases mode i added to my mod. GrantConditionOnPrerequisite unfortunately doesn't work on World actor. If it did, we could remove the dedicated lobby option logic under CrateSpawner and use LobbyPrerequisiteCheckbox instead. On my engine i moved the crate lobby option stuff to MapOptions: trait but i still think best way of doing it is LobbyPrerequisiteCheckbox, so haven't touched it here. I can update this PR if someone can help me with that.

[reaperrr]

Needs rebase.

[MustaphaTR]

Rebased.

[abcdefg30]

From IRC: Using crate types would be better than using an init.

[pchote]

The reason I suggested crate types is that it can then take into account manually placed crates on the map / from lua / etc.

[MustaphaTR]

As i said on IRC:

pchote, abcdefg30 : about that CrateSpawner PR, while it would be good to somehow allow preplaced crates to count towards the trait. I don't think checking the types is a good idea. If i define CrateSpawner on an normal/Player actor, i would expect it to apply Min/Max per player/actor/trait which wouldn't be the case if it was done with types.

[pchote]

What if we keep the trait on the player actor, then add a flag that multiplies the defined min/max by the current player count?

[MustaphaTR]

If we are gonna multipile with player count, i don't think we need to move the trait to player actor.

Another idea i have is to have a seperate manager trait to check the amount of crates on the map and CreateSpawner trait spawns them accordingly.

As i said in the main comment, getting GrantConditionOnPrerequisite on world actor could really help here by getting rid of Specific Lobby options and use LobbyPrerequisiteCheckbox instead.

[pchote]

@MustaphaTR are you planning to continue with this? If not, we should probably close this.

[pchote]

Closing as stale.