Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppearsOnMapPreview #15731

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@MustaphaTR
Copy link
Member

MustaphaTR commented Oct 25, 2018

Adds required logic to fix "#12097 and #13823". Tho i haven't actually updated any map to actually fix the issue.

I put a testcase for stuff that preferably be rendered on RA mod. You can test by opening a map and saving it (seems like it requires a restart so it'll show the new preview).

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch from d4189c0 to c16d5ad Oct 25, 2018

@SoScared

This comment has been minimized.

Copy link
Member

SoScared commented Oct 25, 2018

I assume you want to put RenderOnMapPreview on ^Building as well https://github.com/OpenRA/OpenRA/pull/15731/files#diff-5b0780203fcfc47fcb88e0b8d6d306b9R638

Show resolved Hide resolved OpenRA.Game/Map/Map.cs Outdated
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Oct 25, 2018

This is a high impact feature, so adding it to the milestone.

@pchote pchote added this to the Next + 1 milestone Oct 25, 2018

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch 2 times, most recently from d1568d4 to 72c2424 Oct 26, 2018

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch from 72c2424 to 967c602 Nov 1, 2018

@pchote pchote force-pushed the MustaphaTR:render-on-map-preview branch 2 times, most recently from 0bcd9a9 to a07c596 Nov 4, 2018

@pchote pchote dismissed their stale review Nov 4, 2018

Updated.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 4, 2018

I have pushed over this with some changes to streamline the feature plumbing. 👍 to that part of the PR now.

Two things left to go:

  • Add AppearsOnMapPreview to the other default mods.
  • Implement an update rule and update all the default maps - we will need to add new plumbing to the update rule infrastructure, so might be best if I handle this part.
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 24, 2018

@pchote pchote modified the milestones: Next Release, Next + 1 Nov 25, 2018

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Nov 25, 2018

I would have really liked this for the current release, but the amount of work here (including regenerating all maps and getting them on the resource center) is too risky for the short window that remains for prepping a christmas playtest. Bumping to Next + 1.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Mar 31, 2019

Implement an update rule and update all the default maps - we will need to add new plumbing to the update rule infrastructure, so might be best if I handle this part.

I think last we agreed that you were going to do this and i would do the updating the shipped maps.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 31, 2019

I've been waiting for the other mods to be updated, which is checked in the list above but not actually done!?

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Mar 31, 2019

Ok, i thought i've done that, but it appears that i have actually only appied it to RA. Will rebase this first and do so.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch from a07c596 to c84d73f Mar 31, 2019

Add AppearsOnMapPreview
Allows preplaced actors to be rendered on map preview when saving the
map.

Also removes requirements for ResourceLayer in OpenRA.Game and moves it
to OpenRA.Mods.Common.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch from c84d73f to 65ee435 Mar 31, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Mar 31, 2019

Updated.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Mar 31, 2019

Updated.

Show resolved Hide resolved mods/cnc/rules/defaults.yaml
Show resolved Hide resolved mods/cnc/rules/trees.yaml Outdated
Show resolved Hide resolved mods/d2k/rules/structures.yaml
Show resolved Hide resolved mods/ts/rules/defaults.yaml
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 31, 2019

I'll file a followup PR that makes some tweaks to the map.yaml formatting, adds a new --refresh-map utility command, and ports over the default mod maps after this has been merged.

Add AppearsOnMapPreview to default mods.
To Walls, (Tib)Trees, Ore/Gem Mines and Tech Structures.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:render-on-map-preview branch from 65ee435 to cc918b2 Mar 31, 2019

@pchote

pchote approved these changes Mar 31, 2019

Copy link
Member

pchote left a comment

Confirmed that AppearsOnMapPreview is now declared on all actors that use RadarColorFromTerrain plus tech structures and walls. The rest of the code still LGTM.

@reaperrr reaperrr changed the title Add RenderOnMapPreview Add AppearsOnMapPreview Apr 4, 2019

@reaperrr reaperrr merged commit 9ec8d25 into OpenRA:bleed Apr 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:render-on-map-preview branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.