Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit samplers to 8 in combined.frag. #15754

Merged
merged 1 commit into from Nov 1, 2018

Conversation

pchote
Copy link
Member

@pchote pchote commented Oct 29, 2018

The additional palette sampler wasn't accounted for in the original PR.
This fixes a crash on systems that support a max of 8.

Context: https://logs.openra.net/index.php?year=2018&month=10&day=29#13:09:31

The additional palette sampler wasn't accounted
for in the original PR.
@pchote pchote added this to the Hotfix release milestone Oct 29, 2018
Copy link
Contributor

@reaperrr reaperrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and no regressions spotted in shipping mods

@abcdefg30 abcdefg30 merged commit 95c5c68 into OpenRA:bleed Nov 1, 2018
@abcdefg30
Copy link
Member

abcdefg30 commented Nov 1, 2018

Changelog

@pchote pchote deleted the remove-sampler-nine branch November 18, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants