Prevent unit requests from stacking during production. #15982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the mcv module, increasing the MinimumConstructionYardCount to something like 3 or higher. Doesn't work so well actually, goes out of cash too quickly. According to my test of #15991 before I rebased onto this, the issue this should prevent is probably real on bleed, I haven't tested this fix itself yet, though. |
reaperrr
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers of
IBotRequestUnitProductionneed to be able to check what is already in the queue so that they don't request N duplicates while the first one is still building.Note that this is a speculative fix that I haven't yet tested ingame. @reaperrr did you have a simple way to test the behaviour of this module?