Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple (un)deploy sounds on GrantConditionOnDeploy #16255

Merged
merged 1 commit into from Mar 11, 2019
Merged

Add support for multiple (un)deploy sounds on GrantConditionOnDeploy #16255

merged 1 commit into from Mar 11, 2019

Conversation

abcdefg30
Copy link
Member

No description provided.

@pchote pchote mentioned this pull request Mar 2, 2019
Closed
reaperrr
reaperrr previously approved these changes Mar 8, 2019
View reviewed changes
@abcdefg30
Copy link
Member Author

Rebased.

pchote
pchote reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise LGTM.

OpenRA.Mods.Common/Traits/Conditions/GrantConditionOnDeploy.cs Outdated Show resolved Hide resolved
@abcdefg30
Copy link
Member Author

Updated.

@pchote pchote merged commit 0ab7e0a into OpenRA:bleed Mar 11, 2019
@pchote
Copy link
Member

pchote commented Mar 11, 2019

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/c7e0e1d8c8fcb97496623d68e9db2aba14ea58c5

@abcdefg30 abcdefg30 deleted the deploySounds branch March 11, 2019 21:39
@pchote
Copy link
Member

pchote commented Mar 11, 2019 •
edited

I just noticed that this put the update rule in the wrong directory. Will need a followup to fix this. MakeMobilePausableConditional needs to move too.

@abcdefg30
Copy link
Member Author

#16301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@reaperrr reaperrr reaperrr left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abcdefg30 @pchote @reaperrr