Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple (un)deploy sounds on GrantConditionOnDeploy #16255

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@abcdefg30
Copy link
Member

commented Mar 2, 2019

No description provided.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Rebased.

@pchote
Copy link
Member

left a comment

Just one nit, otherwise LGTM.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:deploySounds branch from e831495 to 5620ff6 Mar 11, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Updated.

@pchote
pchote approved these changes Mar 11, 2019

@pchote pchote merged commit 0ab7e0a into OpenRA:bleed Mar 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:deploySounds branch Mar 11, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

I just noticed that this put the update rule in the wrong directory. Will need a followup to fix this. MakeMobilePausableConditional needs to move too.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.