Require .NET Framework >= 4.7.2 on Windows. #16324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperrr
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises our baseline .NET requirement on Windows from 4.5 to 4.7.2, working towards #15954.
.NET 4.7.2 is the minimum that Microsoft recomments for .NET standard 2.0 [ref], and does not drop support for any of our supported Windows versions [ref].
I have a few more commits locally that improve the Windows packaging by updating NSIS to 3.0.3 to fix #11865 and add HiDPI support to the installer. This change requires a switch to the Ubuntu 16.04 Travis VMs, which breaks the Mono 4.6.2 runtime we currently depend on. This therefore needs to wait until we merge this PR, #16319, #16316, and then bump our Travis runtime to 5.10.0.