Remove pretick argument from Activity.Queue() #16349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-ticking a next activity would break the assumption that activities in a queue would be processed in sequence.
reaperrr
approved these changes
Mar 24, 2019
pchote
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-ticking makes sense for child activities, since they basically run concurrently to their parents. Next activities, however, should not run in parallel but strictly in sequence.
If pretick was set, you could end up with the following sequence of events, which would run counter to general expectations:
A.Tick()
A.Tick()
A.Queue(self, new B(), true)
B.OnFirstRun()
B.Tick()
A.Tick()
A.Tick()
A.OnLastRun()
B.Tick()
Therefore the pretick argument to Activity.Queue() should be removed again.