Updated the LineGraphWidget with new layout #16702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Jun 16, 2019
teinarss
force-pushed
the
update_spec_graphs
branch
from
eb36e4a
to
9dcd0b2
Compare
|
Updated |
ghost
mentioned this pull request
|
Can we please move the player list to the right, add axis labels ("Army Value" / "Game Minute", "Earnings" / "Game Minute"), and drop the then-redundant title row? This would make the graphs a lot more conventional. |
teinarss
force-pushed
the
update_spec_graphs
branch
from
dc0ca4a
to
acfc2b3
Compare
|
See 63069bc for drawing rotated text. Use an angle of |
teinarss
force-pushed
the
update_spec_graphs
branch
2 times, most recently
from
7cfcfe9
to
3aa4c80
Compare
|
Updated and fixed the updates to actual use game minute |
teinarss
force-pushed
the
update_spec_graphs
branch
2 times, most recently
from
b1579b4
to
30d8af9
Compare
pchote
previously approved these changes
Jul 21, 2019
teinarss
force-pushed
the
update_spec_graphs
branch
from
30d8af9
to
059813f
Compare
|
Updated |
pchote
approved these changes
Jul 21, 2019
reaperrr
approved these changes
Jul 21, 2019
| if (self.World.WorldTick % 1500 == 1) | ||
| var timestep = self.World.IsReplay ? replayTimestep : self.World.Timestep; | ||
|
|
||
| if (timestep * self.World.WorldTick % 60000 == 0) |
There was a problem hiding this comment.
This breaks if 60000 can not be divided properly with the timestep. Example case: fast gamespeed in RA. #17002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16597
Closes #16068