Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the LineGraphWidget with new layout #16702

Merged
merged 2 commits into from Jul 21, 2019

Conversation

@teinarss
Copy link
Contributor

commented Jun 16, 2019

Closes #16597
Closes #16068

image

@abcdefg30
Copy link
Member

left a comment

Can we change m to min while we are at it? m usually refers to Meter which is not what we want in this context, I think.

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

@teinarss teinarss force-pushed the teinarss:update_spec_graphs branch from eb36e4a to 9dcd0b2 Jun 16, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

Updated

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Can we please move the player list to the right, add axis labels ("Army Value" / "Game Minute", "Earnings" / "Game Minute"), and drop the then-redundant title row? This would make the graphs a lot more conventional.

@teinarss teinarss force-pushed the teinarss:update_spec_graphs branch from dc0ca4a to acfc2b3 Jul 20, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

See 63069bc for drawing rotated text. Use an angle of (float)Math.Pi / 2.

@teinarss teinarss force-pushed the teinarss:update_spec_graphs branch 2 times, most recently from 7cfcfe9 to 3aa4c80 Jul 21, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

Updated and fixed the updates to actual use game minute

@teinarss teinarss force-pushed the teinarss:update_spec_graphs branch 2 times, most recently from b1579b4 to 30d8af9 Jul 21, 2019

@pchote
Copy link
Member

left a comment

Huge improvement over the current graphs. Great work, and thanks for putting up with my scope creeping. Just a couple of minor code style suggestions then 👍

OpenRA.Mods.Common/Traits/Player/PlayerStatistics.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Widgets/LineGraphWidget.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Widgets/LineGraphWidget.cs Outdated Show resolved Hide resolved

@pchote pchote added the PR: Needs +2 label Jul 21, 2019

@teinarss teinarss force-pushed the teinarss:update_spec_graphs branch from 30d8af9 to 059813f Jul 21, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

Updated

@pchote
pchote approved these changes Jul 21, 2019

@reaperrr reaperrr merged commit f46cad5 into OpenRA:bleed Jul 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
if (self.World.WorldTick % 1500 == 1)
var timestep = self.World.IsReplay ? replayTimestep : self.World.Timestep;

if (timestep * self.World.WorldTick % 60000 == 0)

This comment has been minimized.

Copy link
@GraionDilach

GraionDilach Aug 28, 2019

Contributor

This breaks if 60000 can not be divided properly with the timestep. Example case: fast gamespeed in RA. #17002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.