Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default preview facing to 96 #16754

Merged
merged 1 commit into from Aug 27, 2019

Conversation

reaperrr
Copy link
Contributor

@reaperrr reaperrr commented Jul 6, 2019

No matter how you twist it and turn it (pun intended), 92 is an odd choice.
It's not exactly south-east (that would be 96) and also not a multiple of 8, while all sprite actors in the official mods have at most 32 facings, so 92 would get mapped to the frame linked to facing 88 or 96 anyway (not sure in which direction the engine rounds) and definitely to 96 for any actor with less than 32 facings (RA aircraft and ships as well as all infantry, for example).

So using 96 as default makes more sense.
In my opinion this is also negligible enough that it doesn't need an update rule.

92 is not a multiple of 8, and all sprite actors
in the official mods have at most 32 facings.
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Copy link
Contributor

@teinarss teinarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if we are suppose to merge stuff for Next+1 now?

@reaperrr
Copy link
Contributor Author

Considering we have now have a prep branch we can cherry-pick to and the devtest builds should have shaken out any issues large enough to require a hard reset, I don't see why not, but pinging @pchote just in case.

@reaperrr
Copy link
Contributor Author

reaperrr commented Aug 27, 2019

reaperrr 22:22:31: btw, any objections to starting to merge non-milestone prs into bleed again?

pchote 22:22:47: none
unless they'll obviously cause issues with picking fixes to prep

@reaperrr reaperrr merged commit 07de3ba into OpenRA:bleed Aug 27, 2019
@reaperrr reaperrr deleted the fix-preview-facings branch November 23, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants