Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Target.Positions returning null for invalid FrozenActors. #16929

Merged
merged 1 commit into from Aug 15, 2019
Merged

Fix Target.Positions returning null for invalid FrozenActors. #16929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion OpenRA.Game/Traits/Target.cs
View file
Open in desktop
Expand Up @@ -185,7 +185,8 @@ public IEnumerable<WPos> Positions
case TargetType.Actor:
return actor.GetTargetablePositions();
case TargetType.FrozenActor:
return frozen.TargetablePositions;
// TargetablePositions may be null if it is Invalid
return frozen.TargetablePositions ?? NoPositions;
case TargetType.Terrain:
return terrainPositions;
default:
Expand Down