Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Spawn Child Actor" and "Deployed" checkboxes to the map editor. #16947

Merged
merged 3 commits into from Oct 10, 2019
Merged

Add "Spawn Child Actor" and "Deployed" checkboxes to the map editor. #16947

merged 3 commits into from Oct 10, 2019

Conversation

pchote
Copy link
Member

@pchote pchote commented Aug 16, 2019

This makes it easy for map authors to disable the free harvester spawning from refineries.

@pchote pchote changed the title Add "Spawn Child Actor" checkbox in the map editor actor properties. Add "Spawn Child Actor" and "Deployed" checkboxes to the map editor. Aug 16, 2019
@pchote
Copy link
Member Author

pchote commented Aug 16, 2019

Updated to add a "Deployed" checkbox for GrantConditionOnDeployed.

@pchote pchote added this to the Next+1 milestone Aug 16, 2019
@pchote
Copy link
Member Author

pchote commented Aug 16, 2019

Marking as Next + 1 so this can go together with #16772 and #16900 as an editor improvements theme.

@pchote pchote closed this Aug 26, 2019
@pchote pchote deleted the editor-freeactor-init branch August 26, 2019 08:42
@pchote pchote restored the editor-freeactor-init branch August 26, 2019 08:42
@pchote pchote reopened this Aug 26, 2019
@pchote pchote closed this Aug 26, 2019
@pchote pchote deleted the editor-freeactor-init branch August 26, 2019 08:43
@pchote pchote restored the editor-freeactor-init branch August 26, 2019 08:43
@pchote pchote reopened this Aug 26, 2019
@pchote
Copy link
Member Author

pchote commented Aug 26, 2019

Sorry for the spam - accidentally deleted the branch while cleaning up my repository... twice.

@teinarss
Copy link
Contributor

teinarss commented Sep 2, 2019

Just a thought it would be nice if Deployed actors would shown their deployed state in the viewport.

@pchote
Copy link
Member Author

pchote commented Sep 2, 2019

That is #15494, which is going to be a huge task.

teinarss
teinarss previously approved these changes Sep 2, 2019
View reviewed changes
@reaperrr
Copy link
Contributor

reaperrr commented Oct 5, 2019

Two issues I noticed:

  • The 'Deployed' checkbox doesn't seem to work on the TS Tick Tank.
  • Changing the value of the checkboxes does not enable the OK button.

@pchote pchote mentioned this pull request Oct 5, 2019
Closed
@pchote
Copy link
Member Author

pchote commented Oct 5, 2019 •
edited

Updated.

Changing the value of the checkboxes does not enable the OK button.

This was caused by a conflict / rebase issue against #16772. Rebased and fixed.

The 'Deployed' checkbox doesn't seem to work on the TS Tick Tank.

This is #17184, which isn't related to this PR. (Edit: and now fixed on bleed)

@pchote pchote requested a review from reaperrr October 7, 2019 17:04
@pchote
Copy link
Member Author

pchote commented Oct 7, 2019

Rebased.

@abcdefg30 abcdefg30 merged commit 3860cd1 into OpenRA:bleed Oct 10, 2019
@abcdefg30
Copy link
Member

Changelog

@pchote pchote deleted the editor-freeactor-init branch January 12, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@teinarss teinarss teinarss left review comments

@reaperrr reaperrr Awaiting requested review from reaperrr

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20200503
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchote @teinarss @reaperrr @abcdefg30