Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move voice playing for orders into a helper function #17479

Merged
merged 2 commits into from Dec 23, 2019
Merged

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented Dec 17, 2019

Split from #17472. The changes here are trivial and hopefully easy/quick to review. This will help to reduce the diff at #17472 so we can focus on the order changes there.
(I recommend viewing the second commit like this: 9c03fcd?w=1)

@pchote
pchote approved these changes Dec 17, 2019
@pchote pchote added the PR: Needs +2 label Dec 17, 2019
@reaperrr reaperrr merged commit 959c750 into OpenRA:bleed Dec 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:voice branch Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.