New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IPv6 support for server and direct connect #17571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick initial review as requested. It will be a while before I can put time into thinking about the potential implications of the changes here.
Not all OSes support it. Also multiple sockets are much more convenient if you want explicit bind addresses. I decided against adding an option for overriding the bind addresses in this PR because that would need fundamental announcement system changes which are out of scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time poking at this tonight, sorry for the long delay.
A few crashes and minor style nits:
5e520ae
to
a2e72de
Compare
Everything else seems to work as expected, so I expect 👍 once the issues above are resolved. |
Fixed everything except the error dialog:
|
As I said on IRC, my issue with changing the error dialog in this PR is:
It seems silly to delay IPv6 support over an unrelated scope creep, but if you're not willing for us to change this I don't see much other choice. Merging such a big feature without time to bake on bleed would probably not have been wise anyway. Moving to next + 1 gives this more time to bake and resolves my second point so please go ahead. |
ping @jrb0001. |
@jrb0001 do you mind if I take over this and push to your branch to update this PR? I would like to get this merged before it becomes too late in the Next + 1 cycle. |
@pchote I don't think I will find time and motivation to work on it in the near future so go ahead. |
@jrb0001 can you please check the "Allow edits by maintainers" checkbox at the bottom of the right-hand sidebar? Your repo is currently rejecting my ability to update this PR. |
@pchote That checkbox is enabled, no idea why it would reject your push. |
Probably easiest at this point to file a new pr, so i'll close this one. |
No description provided.