Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DisguiseTooltip condtionality #17601

Merged
merged 1 commit into from Jan 25, 2020

Conversation

MustaphaTR
Copy link
Member

Trait didn't implement ConditionalTrait so it didn't work properly, even tho the TraitInfo implements ConditionalTraitInfo.

Testcase makes their normal name change depending on if you have a Radar Dome or not.

pchote
pchote previously approved these changes Jan 25, 2020
@pchote
Copy link
Member

pchote commented Jan 25, 2020

Testcase will need to be removed before merging.

abcdefg30
abcdefg30 previously approved these changes Jan 25, 2020
@MustaphaTR MustaphaTR dismissed stale reviews from abcdefg30 and pchote via 0570724 January 25, 2020 14:24
@MustaphaTR
Copy link
Member Author

Removed testcase.

@penev92 penev92 merged commit d4b0885 into OpenRA:bleed Jan 25, 2020
@penev92
Copy link
Member

penev92 commented Jan 25, 2020

Changelog

@MustaphaTR MustaphaTR deleted the fix-disguise-tooltip-condtion branch January 30, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants