Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset nextScanTime only when actually scanning for targets. #17694

Merged
merged 1 commit into from Feb 22, 2020
Merged

Reset nextScanTime only when actually scanning for targets. #17694

merged 1 commit into from Feb 22, 2020

Conversation

pchote
Copy link
Member

@pchote pchote commented Feb 16, 2020

Fixes #17691.

The problem occurs because AutoTarget's TickIdle implementation would call ScanAndAttack each tick, which would reset nextScanTime and then do nothing because AttackFollow disables this kind of scanning. When AttackFollow then wants to scan, it can't do anything because nextScanTime > 0. Moving the nextScanTime reset after the disable check prevents TickIdle from resetting it.

@pchote pchote added this to the Next Release milestone Feb 16, 2020
@reaperrr reaperrr merged commit 28f7604 into OpenRA:bleed Feb 22, 2020
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/e601f958ef03760bf204e9e817f3cb7f1acdc2fc...e4e94ba6998d978203f67dca72e66d37b115e0fa

@pchote pchote deleted the fix-ftur-scan branch July 18, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

@reaperrr reaperrr reaperrr approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20200503
Development

Successfully merging this pull request may close these issues.

Flame tower does not autoattack enemy units, nor does the AA gun, but the Tesla coil does
3 participants
@pchote @reaperrr @Mailaender