Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetActorsAt(CPos, SubCell) with special-case subcells. #17756

Merged
merged 1 commit into from Mar 3, 2020
Merged

Fix GetActorsAt(CPos, SubCell) with special-case subcells. #17756

merged 1 commit into from Mar 3, 2020

Conversation

pchote
Copy link
Member

@pchote pchote commented Mar 2, 2020

Fixes #17755.

A simple testcase is to set WarnProbability: 0 and CrushedByFriendlies: true and use a tank to crush your own infantry.

@pchote
Fix GetActorsAt(CPos, SubCell) with special-case subcells.
11fde9a 
If given FullCell or Any we should be returning actors in
any subcell, not none.
@pchote pchote added this to the Next Release milestone Mar 2, 2020
@abcdefg30 abcdefg30 merged commit d2f306e into OpenRA:bleed Mar 3, 2020
@abcdefg30
Copy link
Member

Changelog

@pchote pchote deleted the fix-crushing branch July 18, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20200503
Development

Successfully merging this pull request may close these issues.

[playtest-20200301+] Firing rifle soldier is uncrushable
3 participants
@pchote @abcdefg30 @Mailaender