Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align lobby bits in the player tab in TD #17790

Merged
merged 1 commit into from Mar 25, 2020
Merged

Align lobby bits in the player tab in TD #17790

merged 1 commit into from Mar 25, 2020

Conversation

dragunoff
Copy link
Contributor

I noticed that some of the lobby bits are misaligned. Minor UI polish.

lobby-bits-td

@pchote pchote added this to the Next Release milestone Mar 10, 2020
abcdefg30
abcdefg30 previously approved these changes Mar 13, 2020
View reviewed changes
pchote
pchote reviewed Mar 18, 2020
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i found a couple of additional inconsistencies that we should also fix:

mods/cnc/chrome/lobby-players.yaml
@@ -198,7 +198,6 @@ Container@LOBBY_PLAYER_BIN:
Template: ANONYMOUS_PLAYER_TOOLTIP
Label@NAME:
X: 39
Y: 0 - 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need the same change in TEMPLATE_EMPTY too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TEMPLATE_NONEDITABLE_SPECTATOR as well.

mods/cnc/chrome/lobby-players.yaml
@@ -148,7 +148,7 @@ Container@LOBBY_PLAYER_BIN:
Height: 25
Font: Regular
Image@STATUS_IMAGE:
X: 521
X: 529
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we'll need the same change in TEMPLATE_EDITABLE_SPECTATOR and TEMPLATE_NONEDITABLE_SPECTATOR too.

@pchote
Copy link
Member

pchote commented Mar 18, 2020

Do the other mods have similar issues? It would be good to file a second PR fixing those for the playtest too.

@dragunoff
Copy link
Contributor Author

Do the other mods have similar issues? It would be good to file a second PR fixing those for the playtest too.

I checked the other mods before filing this PR and I didn't spot any issues. Should I file another PR against the prep branch?

@pchote
Copy link
Member

pchote commented Mar 18, 2020

Sorry, I should have added "if needed" to that sentence. I meant that any fixes, if needed, for the other mods didn't need to block merging this one.

@dragunoff
Copy link
Contributor Author

Updated to address comments.

@reaperrr reaperrr merged commit be19e13 into OpenRA:bleed Mar 25, 2020
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/a5d4c732f069f958052b4c880d22ba0808a9fc39...81449281c4645b825367c66a3dba79e0cba6847c

ecbcc9c

@dragunoff dragunoff deleted the fix/lobby-bits-alignment-td branch May 25, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@reaperrr reaperrr reaperrr approved these changes

@abcdefg30 abcdefg30 abcdefg30 left review comments

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20200503
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dragunoff @pchote @reaperrr @abcdefg30