Drop FlyAttackRun targets when we don't have valid armaments against them #18511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#17935 has been merged. |
teinarss
reviewed
Jan 22, 2021
teinarss
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the remark from #18470 (comment).
Has a soft dependency on #17935.
I probably need to adjust
StrafeAttackRuntoo, but haven't tested that and am throwing this out in case someone has comments. What I was wondering about is if we can move the target (visibility and validity) recalculation code and then theHasAnyValidWeaponscheck to a common helper method every activity can call instead of seemingly duplicating that code into every attack activity.