Added Tiberian Sun burning trees

[Mailaender]

Closes #18657.

[pchote]

#18657 is specifically asking for the random spread probability (with documentation on how it worked!), and when discussing the feature in Discord @henskelion also specifically talked about the fire animation growing/dying off on the same tree instead of being picked randomly.

Can we justify not implementing this correctly in our TS?

[Mailaender]

Updated to differentiate big and large fires. https://github.com/LipkeGu/TSIniFiles/blob/master/rules.ini#L354 mentions it in the comments, but the logic is hidden.

[pchote]

The logic isn't hidden, you just have to read the FIRE1, FIRE2, FIRE3 definitions in art.ini.

[Mailaender]

Do you think the random element I omitted here is essential?

[pchote]

We are trying to recreate TS, which means that the default standard should be to match its behaviour. We know how the original behaviour here worked, so I think that the onus here is to justify why we should deliberately choose to ignore that and implement something different - which will likely require more work overall to polish and (maybe?) balance than using the original parameters.

[Mailaender]

Indeed, it was a bit lazy to just shovel the @OpenHV setup, so I wrote a new trait that takes the original random elements from https://www.modenc.renegadeprojects.com/TreeFlammability into account. In practice the result is not so different.

[ABrandau]

A couple of suggestions:

• Damage can be applied with a changes health trait, i dont know if its necessary for the trait,
• The trait could enable a condition to the actor to allow more customization into the unit.
• A delay tag could be added into trait to customize how long it takes for the entire forest to be on fire?

On the TS behaviour.

Trees are not set on fire when they take damage, they seem to be set on fire only when attacked with a fire weapon, in fact, bullets do not harm trees.

Damage doesnt set trees of fire either, only fire damage (perhaps ion storms too if we get to that stage?)

[Mailaender]

Rewrote this to be more generic, use only the condition system instead of dealing damage and added a delay interval.

[phrohdoh]

Inline documentation suggestions.

[Mailaender]

Updated.

[abcdefg30]

How much influence do we have on the graphics? The tree in the middle is burning but that is not really visible at all.

[Mailaender]

I tweaked Z coordinate and offset a bit.

[Mailaender]

Tried the other blend modes. Nothing quite matches the effects from Tiberian Sun yet.

[pchote]

Nothing quite matches the effects from Tiberian Sun yet.

This was fixed by #19122, which has caused a rebase conflict.

[pchote]

This is important to the feature to work, but noting that this could potentially bring a significant performance regression (but hopefully now much less than when we changed FrozenUnderFog → HiddenUnderShroud in the first place).

[Mailaender]

Rebased.

[abcdefg30]

There are 8 warheads with sparky=yes in https://github.com/LipkeGu/TSIniFiles/blob/4cc5adac88b012e27a6a82ba7c93d182451d9d64/rules.ini , so I assume this is still missing from a few weapons (like the grenade).

Lgtm otherwise. ✅

[Mailaender]

Added it to Orca, Disc Throwers and Cyborg Commando according to RULES.INI.

[abcdefg30]

The SonicZap should also be able to affect trees.

[Mailaender]

Updated.

[Mailaender]

Updated.

[abcdefg30]

Changelog