Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RA/TD turret facings sometimes breaking during make anim #18738

Merged
merged 3 commits into from Oct 18, 2020
Merged

Fix RA/TD turret facings sometimes breaking during make anim #18738

merged 3 commits into from Oct 18, 2020

Conversation

reaperrr
Copy link
Contributor

@reaperrr reaperrr commented Oct 17, 2020 •
edited

Fixes #18618.
Fixes default facing of Gun Turrets (compared to make anim and original, we were 1 sprite facing off).
Fixes default facing of RA Flak cannon (compared to make anim and original, we were 2 sprite facings off).
Enables recoil anim for Gun Turrets (not for AA cannon, since it looks bad with its very high fire rate).

@reaperrr reaperrr added this to the Next Release milestone Oct 17, 2020
pchote
pchote previously approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clever way to combine a bugfix with adding the recoil state (that I hadn't even realized we were missing!).

Just a couple of minor points:

mods/cnc/rules/structures.yaml Outdated Show resolved Hide resolved
mods/ra/rules/structures.yaml Outdated Show resolved Hide resolved
@reaperrr
Fix default facing of RA/TD Gun Turrets
f9e6073 
Compare with make anim and original, 224 was
one facing too far.
@reaperrr
Copy link
Contributor Author

Updated.

pchote
pchote previously approved these changes Oct 18, 2020
View reviewed changes
@reaperrr
Fix RA/TD defense turrets facing issues
5884314 
By using WithSpriteTurret instead of
WithEmbeddedTurretSpriteBody.
@reaperrr
Enable recoil anim on RA/TD Gun Turrets
3abe6bd
@reaperrr
Copy link
Contributor Author

Updated:

  • added comments
  • fixed a small oversight, first frame of the agunmake wasn't empty (now uses gunmake frame 1, too)
  • applied principle on RA SAM site as well

abcdefg30
abcdefg30 approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@abcdefg30 abcdefg30 merged commit a1c8cba into OpenRA:bleed Oct 18, 2020
@abcdefg30
Copy link
Member

Changelog

@reaperrr reaperrr mentioned this pull request Oct 31, 2020
Open
@reaperrr reaperrr mentioned this pull request Dec 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@pchote pchote pchote left review comments

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20210321
Development

Successfully merging this pull request may close these issues.

Turret is pointing in the wrong direction
3 participants
@reaperrr @abcdefg30 @pchote