Removed hard-coded .vqa assumptions from the engine #18773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mailaender
force-pushed
the
videoloader
branch
from
e3f4931
to
1ec5125
Compare
abcdefg30
previously approved these changes
Nov 12, 2020
|
Looks good to me. RA and TD videos work (tested briefings and asset browser). Didn't test D2k. LGTM, needs a minor rebase, though. |
reaperrr
previously approved these changes
Jan 10, 2021
|
Rebased. |
Mailaender
force-pushed
the
videoloader
branch
from
1ec5125
to
fbefca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12775.