Use tie breaks to determine sort order in WorldRenderer.GenerateRenderables #18774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
force-pushed
the
render-sort
branch
from
859884a
to
46c81b3
Compare
abcdefg30
reviewed
Oct 25, 2020
Comment on lines
154
to
155
| compared = x.Pos.Z.CompareTo(y.Pos.Z); | ||
| return compared; |
There was a problem hiding this comment.
This can simplify to return x.Pos.Z.CompareTo(y.Pos.Z).
There was a problem hiding this comment.
Also, wouldn't it make sense to compare z before x or y?
There was a problem hiding this comment.
Simplified.
I chose this order as X is often a useful first-element-that-actually-differs. Z often is no help. That said, it is arbitrary so I can switch it if that's better in some way?
There was a problem hiding this comment.
We can leave it like this then.
RoosterDragon
force-pushed
the
render-sort
branch
from
46c81b3
to
9b0c5ea
Compare
abcdefg30
approved these changes
Nov 1, 2020
pchote
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18761
#18709 introduced a bug where renderables with the same z position would swap at random each frame, leading to flickering. This addresses that issue by using some tie-breaks to arbitrarily, but consistently, decide on the top-most element.