feat: ActorSpawnManager.SpawnInterval supports 1 or 2 values #18794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrohdoh
force-pushed
the
feat/actor-spawn-manager_interval-range
branch
from
c0ec777
to
361f0fe
Compare
phrohdoh
commented
Oct 31, 2020
| @@ -25,8 +25,8 @@ public class ActorSpawnManagerInfo : ConditionalTraitInfo, Requires<MapCreepsInf | |||
| [Desc("Maximum number of actors.")] | |||
| public readonly int Maximum = 4; | |||
|
|
|||
| [Desc("Time (in ticks) between actor spawn.")] | |||
| public readonly int SpawnInterval = 6000; | |||
| [Desc("Time (in ticks) between actor spawn. Supports 1 or 2 values.\nIf 2 values are provided they are used as a range from which a value is randomly selected.")] | |||
There was a problem hiding this comment.
The \n is not strictly necessary, can remove it if we want.
abcdefg30
reviewed
Oct 31, 2020
phrohdoh
force-pushed
the
feat/actor-spawn-manager_interval-range
branch
from
361f0fe
to
c89661f
Compare
phrohdoh
force-pushed
the
feat/actor-spawn-manager_interval-range
branch
from
c89661f
to
1ef0eeb
Compare
abcdefg30
reviewed
Oct 31, 2020
abcdefg30
reviewed
Oct 31, 2020
Providing 2 values creates a range from which a value is randomly selected.
phrohdoh
force-pushed
the
feat/actor-spawn-manager_interval-range
branch
from
1ef0eeb
to
ffed034
Compare
abcdefg30
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged this will close #18788.
Testcase: