Added support to detect game installations by uninstaller location

[Mailaender]

This is for cases where no InstallFolder is available, but the uninstaller executable location is written to the registry and it is located in the game directory, which is quite common place in the 90s.

[pchote]

This sounds reasonable, but can you please link to a specific example for this? I assume this is being implemented for a mod.

[Mailaender]

[pchote]

Have you tested that this does not break the existing use case? The documentation at https://docs.microsoft.com/en-us/dotnet/api/system.io.path.getdirectoryname?view=net-5.0 suggests that it will.

/*
This code produces the following output:
...
GetDirectoryName('C:\MyDir\MySubDir') returns 'C:\MyDir'
...
*/

[Mailaender]

I didn't expect that behavior from the function. However, the Origin installation has trailing \ which should work:

GetDirectoryName('C:\MyDir\') returns 'C:\MyDir'

Can't test this as OpenRA is stuck checking for the disc drive. I have a DVD drive, but it is not detected by Windows 10.

[pchote]

I think a better approach here would be to rename SourceType.Install to SourceType.RegistryDirectory and then add a new SourceType.RegistryDirectoryFromFile that is used to distinguish between the two behaviours.

[Mailaender]

Yes, I agree that will be safer.

[pchote]

This looks fine to me, but one more simplification inline below. We have had several bugfixes in the installation logic recently, so can you please also rebase this on the latest bleed?

[Mailaender]

Updated as instructed.

[pchote]

LGTM but not tested

[reaperrr]

Also untested, but lgtm anyway

[reaperrr]

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/39d2134c622e7f735341282e857636f7b5db6e54...06f3a387988f98aa0679730ba0f01029fa770bd6