Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse .aud file metadata correctly #18937

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Parse .aud file metadata correctly #18937

merged 3 commits into from
Dec 24, 2020

Conversation

Mailaender
Copy link
Member

This is a followup of #18911.

abcdefg30
abcdefg30 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm, the sounds from our downloadable packages work and I still get nuyell1.aud is not a valid sound file! when trying to play an unsupported aud. 👍

pchote
pchote approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that these would be better PRed as commits within a larger PR that actually finishes the feature, but ok.

@pchote pchote merged commit 04cda69 into OpenRA:bleed Dec 24, 2020
@pchote
Copy link
Member

pchote commented Dec 24, 2020

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/2c3b40dc3333660a2d9ef66cce5b28468161e6f5

@Mailaender Mailaender deleted the aud-flags branch December 25, 2020 09:08
@Mailaender
Copy link
Member Author

https://github.com/Mailaender/OpenRA/tree/aud-8 is on hold. I have no idea to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mailaender @pchote @abcdefg30