Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add player random faction info in the objectives panel #18980

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Add player random faction info in the objectives panel #18980

merged 1 commit into from
Dec 30, 2020

Conversation

dragunoff
Copy link
Contributor

Player view:
102927272-5155d300-449f-11eb-85f6-3a1a8a937b78

Spectator view:
103237112-5f986900-494f-11eb-816a-465f9e0c1ff7

Closes #18342

phrohdoh
phrohdoh approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@phrohdoh phrohdoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Smittytron
Smittytron approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pchote pchote merged commit ff60540 into OpenRA:bleed Dec 30, 2020
@pchote
Copy link
Member

pchote commented Dec 30, 2020

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/b673cf8b8cd76f8ef48cab9f612b413b36dc4776

@dragunoff dragunoff deleted the feature/random-faction-info branch June 3, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@phrohdoh phrohdoh phrohdoh approved these changes

@Smittytron Smittytron Smittytron approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add random faction information to the replay viewer
4 participants
@dragunoff @pchote @phrohdoh @Smittytron