Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Code launch configuration to match .NET 5 migration #18992

Closed

Conversation

phrohdoh
Copy link
Member

@phrohdoh phrohdoh commented Jan 2, 2021

5e74e58 has us producing and running OpenRA.dll instead of OpenRA.exe, so update the VSCode launch config (without these changes, launching will fail with a file-not-found error).

@Mailaender Mailaender changed the title update vscode launch configuration to match 5e74e58b2204b223ab100cba09a151eeac888910 Update VS Code launch configuration to match .NET Core migration Jan 2, 2021
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works. Thanks.

@phrohdoh phrohdoh changed the title Update VS Code launch configuration to match .NET Core migration Update VS Code launch configuration to match .NET 5 migration Jan 2, 2021
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on Windows which still uses the .exe (also in the launch scripts).

@pchote
Copy link
Member

pchote commented Jan 2, 2021

We're still not finished with migrating our development toolchain to .NET 5 and there are more breaking changes for launch.json to come. The macos and linux mono overrides will be removed, so should not be touched here.

Instead, i suggest adding a windows-specific override for the program back to exe (or just wait, and fix everything together in the next PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants