Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix. Call EndGame in one place of server main loop. Ensure UPnP port … #19021

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Fix. Call EndGame in one place of server main loop. Ensure UPnP port … #19021

merged 1 commit into from
Feb 14, 2021

Conversation

anvilvapre
Copy link
Contributor

@anvilvapre anvilvapre commented Jan 9, 2021 •
edited by Mailaender
Loading

Fixes #18804. Assuming UPnP port forward needs to be removed in all cases.

abcdefg30
abcdefg30 approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but code changes look reasonable.

pchote
pchote approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a UPnP compatible setup to test this with, but the code changes look sensible so I think we are safe here.

@pchote pchote merged commit f176a0e into OpenRA:bleed Feb 14, 2021
@pchote
Copy link
Member

pchote commented Feb 14, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/6b19a53d99c2e6b48f77616eee75a51a7b6be45c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server EndGame, UPnP port forward not always removed
3 participants
@anvilvapre @pchote @abcdefg30