Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a "structure sold" notification #19043

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Added a "structure sold" notification #19043

merged 2 commits into from
Jan 27, 2021

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender commented Jan 12, 2021 •
edited by pchote
Loading

Closes #19044.
Closes #19054.

@deleted-user-1
Copy link
Contributor

I wonder if this should be a Notification field on Sellable? Most notifications are defined on the relevant trait, with some exceptions like BaseAttackNotifier and HarvesterAttackNotifier (could maybe move to a generic ActorUnderAttackNotification trait?), ResourceStorageWarning (could maybe move to PlayerResources?), StartGameNotification, ActorLostNotification and CaptureNotification.

@Mailaender
Copy link
Member Author

I agree. A trait initialization may be too costly for this tiny feature. Added it to the base trait and kept it disabled by default.

@deleted-user-1
Copy link
Contributor

#19044

@pchote pchote mentioned this pull request Jan 15, 2021
Closed
@pchote pchote added this to the Next Release milestone Jan 17, 2021
@pchote
Copy link
Member

pchote commented Jan 17, 2021

LGTM aside from the issue @matjaeck raised above. I agree it makes sense to take the whole thing for prep, so added to milestone and tweaked assignments/closes.

@pchote
Copy link
Member

pchote commented Jan 24, 2021

Ping @Mailaender.

Smittytron
Smittytron approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abcdefg30 abcdefg30 merged commit 28ddab7 into OpenRA:bleed Jan 27, 2021
@abcdefg30
Copy link
Member

Changelog

@Mailaender Mailaender deleted the structure-sold branch January 27, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote left review comments

@deleted-user-1 deleted-user-1 deleted-user-1 left review comments

@abcdefg30 abcdefg30 abcdefg30 approved these changes

@Smittytron Smittytron Smittytron approved these changes

Assignees
No one assigned
Labels
PR: For stable PR: Needs +2
Projects
None yet
Milestone
Release 20210321
5 participants
@Mailaender @deleted-user-1 @pchote @abcdefg30 @Smittytron