Remove ScriptTriggers from indestructible map deco actors #19056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes it from destroyed fields, trees and rocks in RA and C&C. This trait isn't free in terms of performance due to all the INotify* calls, and the mentioned actors should rarely - if ever - need it. Besides, if a mission ever really needs this on those actors, the trait can be added back via map rules.
reaperrr
changed the title
phrohdoh
approved these changes
Jan 15, 2021
pchote
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
ScriptTriggerstrait from trees, rocks and destroyed fields (in other words, indestructible map decoration actors) in RA and C&C.This trait isn't free in terms of performance due to all the INotify* calls, and the mentioned actors should rarely - more likely never - need it. Besides, if a mission ever really needs this on those actors, the trait can be added back via map rules.
Split from #18588 to get the uncontroversial(?) and easy stuff out of the way, as some maps have lots of trees so there might already be a small win from this alone.