Add shadow rendering for resource sprites. #19059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the shadow is rendered where there is no (or very little) tib.
|
|
After some investigation, i'm pretty sure that is caused by #12229. Increasing the tiberium's Offset z coordinate restores the missing sprite, but we should fix the underlying problem instead of bodging that. We shouldn't try to fix that here, but this has become another useful testcase. |
teinarss
approved these changes
Jan 21, 2021
reaperrr
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements #18814 on top of the new TerrainSpriteLayer code.
Closes #18780.
The shadow layer is only created if at least one of the resource sequences defines shadow sprites, so the impact on non-ts mods should be negligible (and TS already defines shadows in its sequences).