Fix Contrail solid delay of 4 &color fix #19089
Conversation
|
Turned to draft, I should still smooth from tail direction |
|
OK, it is cool now |
|
Contrails are still invisible when There might be a more elegant solution, this is just the best I could come up with. |
That sounds like a naming/definition issue: you need two points to define a line, so the shortest option exposed to the modder as length 1 should be when there is two points. |
Good point,
update: |
|
And probably we should directly add 1 to all length when contrail is created after this PR? Now as you can see if renderlength == 2, the Render() will only renders 1 length, which is also buggy. |
dnqbob
force-pushed
the
contrail-fix
branch
2 times, most recently
from
e9847bd
to
c45e972
Compare
|
@pchote I suddenly worry that, will .Net executes the by the order from left to right and don't optimize *1000 and /1000? |
|
Those likely shouldn't be optimized to avoid big rounding errors? |
yes. although it performs like it won't optimize it. Update: |
|
And we can now use this contrail as high speed bullet line |
|
OK since we worry about storage and time cost so I use a simple and stupid way. |
|
fix comment |
| @@ -73,11 +73,31 @@ public void Render(WorldRenderer wr) | |||
| // Start of the first line segment is the tail of the list - don't smooth it. | |||
| var curPos = trail[Index(next - skip - 1)]; | |||
| var curColor = color; | |||
| for (var i = 0; i < length - skip - 4; i++) | |||
|
|
|||
| for (var i = 1; i < renderLength; i++) | |||
There was a problem hiding this comment.
Why was this changed from 0 to 1?
There was a problem hiding this comment.
Because renderLength is now length - skip, for readable I make i = 1 instead of make i < renderLength - 1.
If we make i = 0 base on this design, the contrail will be rendered to (0,0) in map.
There was a problem hiding this comment.
This loop part was tricky and with low readability so I tested frequently to get the correct boundary.
|
So should I mark the conversation as solved or the reviewer? |
|
I guess I also need a rebase |
| nextZ += prepos.Z; | ||
| } | ||
|
|
||
| nextPos = new WPos((int)(nextX / k), (int)(nextY / k), (int)(nextZ / k)); |
There was a problem hiding this comment.
| nextPos = new WPos((int)(nextX / k), (int)(nextY / k), (int)(nextZ / k)); | |
| var nextPos = new WPos((int)(nextX / k), (int)(nextY / k), (int)(nextZ / k)); |
And then remove the var nextPos = WPos.Zero; line above.
| // Need at least 4 points to smooth the contrail over | ||
| if (length - skip < 4) | ||
| var renderLength = length - skip; | ||
| if (renderLength <= 0) |
There was a problem hiding this comment.
I assume with a renderLength of 1 we will never be able to draw a line, so this should be:
| if (renderLength <= 0) | |
| if (renderLength <= 1) |
?
There was a problem hiding this comment.
fixed, but we may need to comment it here about why it must >=1 (and I don't know how to explain on this)
| @@ -63,8 +65,10 @@ public IRenderable OffsetBy(in WVec vec) | |||
| public IFinalizedRenderable PrepareRender(WorldRenderer wr) { return this; } | |||
| public void Render(WorldRenderer wr) | |||
| { | |||
| // Need at least 4 points to smooth the contrail over | |||
| if (length - skip < 4) | |||
| // Note: The length of contrail is now acutally the number of the points to draw the contrail | |||
There was a problem hiding this comment.
Minor spelling nit: "actually"
fix #19084
Make contrail work for both projectile and aircraft with smoothest behavior
without solid delaysreduce solid delay to 1.And make color fade away with only alpha, not becoming white first.