Add MSADPCM audio format decoding support #19125
Conversation
|
Added a testcase, Need to extract track from the meg-package with https://modtools.petrolution.net/tools/MegEditor and update the filename. |
|
The new audio player in #19143 should make testing this much easier: add the meg package loader and mount the package in mod.yaml, then select it in the asset browser. |
|
Works as expected and everything else lgtm, so 👍 once the points above are sorted. |
teinarss
force-pushed
the
MSADPCM_audio_
branch
2 times, most recently
from
d10c616
to
a7fe8fb
Compare
| : nibble; | ||
|
|
||
| s2 = s1; | ||
| s1 = (short)(twosCompliment * idelta + predict).Clamp(-32768, 32768); |
There was a problem hiding this comment.
Ugh, sorry, this actually needs to be .Clamp(-32768, 32767)!
Clamping to +32768 introduces noticeable audio glitches in certain files (e.g. EN-US\TDR_SFX_UNT_YESSIR1.V03_EN-US.WAV).
LGTM after this final fix. Maybe also a good time to remove the testcase?
If anyone else wants to test this i recommend rebasing on top of #19143, adding MegV3 to mod.yaml's PackageFormats list, and mounting MUSIC.MEG or SFX2D_EN-US.MEG in the packages list.
teinarss
force-pushed
the
MSADPCM_audio_
branch
from
a7fe8fb
to
8d96704
Compare
|
Updated. |
Resurrection of #18552
Supersedes and closes #18552.