Implement "glow in the dark" TS animations #19131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
force-pushed
the
split-attack-palette
branch
from
7e680ba
to
7243e70
Compare
teinarss
reviewed
Feb 5, 2021
pchote
force-pushed
the
split-attack-palette
branch
2 times, most recently
from
0c6cd43
to
2176732
Compare
|
Fixed those and the issues reported by the linter. |
pchote
force-pushed
the
split-attack-palette
branch
from
2176732
to
465d8a4
Compare
pchote
force-pushed
the
split-attack-palette
branch
from
465d8a4
to
db65eff
Compare
|
Rebased and ready for review. |
|
Mobile sensor array is missing its lighting animation when deployed. |
|
Good spotting!
It turns out that this animation was never defined, so wasn't flagged by my automated reporting. I added a new commit to fix this and also fix the graphical glitches on snow maps. |
- Force temperate palette to avoid glitches on snow maps - Add missing active animation
pchote
force-pushed
the
split-attack-palette
branch
from
431ad9b
to
dc895f3
Compare
|
Rebased for good measure. |
teinarss
approved these changes
Mar 15, 2021
reaperrr
approved these changes
Mar 20, 2021
This was referenced Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lights.mov
This PR implements the "bright" palette ranges that were hardcoded for infantry and certain building animations in TS, as well as fixing many small errors in the sequence definitions. Best tested on a relatively dark map like Sunstroke, and the map editor can be used to quickly place buildings and check animations in normal and damaged states (muzzle flashes need to be tested in a real game).
Most animations that use this feature contain a mix of bright and non-bright colours, which I handle by creating new
player-nobrightandplayer-nomuzzlepalettes that blank out the bright ranges, and correspondingbrightandmuzzlepalettes that blank out everything else. Actors then render the animation twice, once with theplayer-no*and then again withbrightormuzzletogether withIgnoreWorldTint: True. A small number of animations only use the bright colours, so only specify the-brightversion.I'm fairly confident that this covers all of the animations that we currently define because I started this process by modifying the
CheckMissingSpritesutility command to report all sprites that used the bright colours, and only crossed animations off the list after I had verified them working ingame.Fixes #13046.
Depends on #19122.There are two other issues that aren't strictly blockers, but would be nice to resolve first:
WithIdleOverlaytoWithOverlayand implement a properWithIdleOverlaytrait (including randomIntervalsupport) to properly implement the original refinery flame behaviour.Cloakpalette override and reimplement using alpha: the stealth generator has always broken a few animations (like the refinery flame animation), but now breaks many more.