Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower Z-Offsets of decorations that overlap FIX #19137

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Lower Z-Offsets of decorations that overlap FIX #19137

merged 2 commits into from
Feb 14, 2021

Conversation

Smittytron
Copy link
Member

Closes #13939
Closes #17832

Bridges have overlap too but they can't hold sequences.

@pchote
Copy link
Member

pchote commented Feb 14, 2021

The current bridge rendering isn't compatible with remastered asset switching either.
I the best approach there (which is on my list to implemement and PR in the nearish future) will be to introduce a new rendering trait for drawing tiled sprites that we use for both bridges and bibs. Bridge artwork can then use sequences and have zoffsets applied.

pchote
pchote approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could find a cleaner solution, but this seems to work ok.

@pchote pchote merged commit 16fa1ef into OpenRA:bleed Feb 14, 2021
@pchote
Copy link
Member

pchote commented Feb 14, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/5ce40920950c297019a40b23cfdc34b8a8e230a7

@Smittytron Smittytron deleted the sd-offsets branch February 14, 2021 14:48
@Smittytron Smittytron mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@reaperrr reaperrr reaperrr approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ore mine / repair pad Z Offset issues Repair Pad & Service Depot are overlapped by civilian crop fields
3 participants
@Smittytron @pchote @reaperrr