Remove SmokeTrailWhenDamaged

[reaperrr]

One of the most outdated and limited traits remaining, which can do nothing LeavesTrails doesn't cover by now.
Had this on my agenda for quite a while, just never found the motivation to deal with the update rule until now.

All yaml changes done via update rule.
The two edge cases not covered by our mods (explicit Sprite definition, as well as update message when a MinDamage of for example Medium was defined), have been tested and confirmed to work locally.

Closes #10864.
Closes #19104.

[pchote]

Looks fine overall, just a couple of style nits

[reaperrr]

Updated.

I decided to add TrailWhenStationary: true via update rule to replicate bleed behaviour, but only manually added it to the 3 RA attack helis and their husks instead of running the update rule on both affected mods again.

[pchote]

The smoke animation for stationary helicopters still doesn't look very good IMO (now a static blob of grey pixels, still worse than the SmokeTrailWhenDamaged behaviour).

I have two ideas on how we could improve this:

• Change helicopters to use WithDamageOverlay (which uses the smoke_m animation). They move slow enough that the lack of trailing doesn't look quite so bad.
• Remove the smoke trails from aircraft completely (I just checked to confirm that the original game did not have them).

We could drop TrailWhenStationary again then.
IMO the first would be better than the second.

[Smittytron]

Would this close #10864?

[reaperrr]

I think so.

[reaperrr]

The smoke animation for stationary helicopters still doesn't look very good IMO (now a static blob of grey pixels, still worse than the SmokeTrailWhenDamaged behaviour).

I just forgot to set StationaryInterval as well, updated and now looks like on bleed while not moving, too.

Change helicopters to use WithDamageOverlay (which uses the smoke_m animation). They move slow enough that the lack of trailing doesn't look quite so bad.

On bleed the duration of smoke_m is fairly short, we need #19240 to do that properly. In my opinion we should stick to reproducing bleed here and get both PRs merged, RA/TD need another PR dedicated to polishing things up in terms of smoke offsets and durations anyway, once the plumbing is there.

[Smittytron]

LGTM. Needs rebase.

[teinarss]

@pchote anything before to add before I merge this?

[reaperrr]

Rebased again.

[pchote]

@pchote anything before to add before I merge this?

Nope.

[pchote]

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/6e3cedc8ca0e75544884b7863a6458a05bfcffc0