Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expression body syntax #19189

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Use expression body syntax #19189

merged 1 commit into from
Mar 7, 2021

Conversation

teinarss
Copy link
Contributor

No description provided.

Copy link
Member

@penev92 penev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checks out. 👍
Note that this can easily conflict with 100 other PRs, which is going to be a nightmare either way, but I'd like to get it merged ASAP instead of letting it go to infinite rebase hell.

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not a fan of having such a big set of changes all in one commit, but considering that this was an automated change I think the risk introduced by manually tweaking the PR + delays that would otherwise lead to rebase conflicts and even more manual changes... is worse than taking this as-is, and dealing with any other issues in followups.

@pchote pchote merged commit 4a1e4f3 into OpenRA:bleed Mar 7, 2021
@teinarss teinarss deleted the update_syntax2 branch April 15, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants