Change to use pattern matching #19200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
previously requested changes
Mar 1, 2021
pchote
reviewed
Mar 2, 2021
| @@ -81,8 +81,7 @@ public bool Equals(Hotkey other) | |||
|
|
|||
| public override bool Equals(object obj) | |||
| { | |||
| var o = obj as Hotkey?; | |||
| return o != null && o == this; | |||
| return obj is Hotkey o && (Hotkey?)o == this; | |||
There was a problem hiding this comment.
does Hotkey vs Hotkey? matter here?
There was a problem hiding this comment.
Never seen it done like this, usually its done like return obj is Hotkey o && Equals(o);
| @@ -55,8 +55,7 @@ public bool Equals(float3 other) | |||
|
|
|||
| public override bool Equals(object obj) | |||
| { | |||
| var o = obj as float3?; | |||
| return o != null && o == this; | |||
| return obj is float3 o && (float3?)o == this; | |||
teinarss
force-pushed
the
pattern_matching
branch
from
63d1dcf
to
dd23c84
Compare
pchote
previously approved these changes
Mar 7, 2021
teinarss
force-pushed
the
pattern_matching
branch
from
dd23c84
to
0e93770
Compare
|
Can we get a second review and merge here before we get more rebase issues? |
reaperrr
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.