Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nullable type handling in Lua docs. #19201

Merged
merged 1 commit into from Mar 10, 2021
Merged

Conversation

pchote
Copy link
Member

@pchote pchote commented Feb 28, 2021

Fixes #19178.

Before:

<tr><td align="right" width="50%"><strong>void DisplayMessage(string text, string prefix = Mission, Nullable`1 color = nil)</strong></td><td>Display a text message to the player.</td></tr>

After:

<tr><td align="right" width="50%"><strong>void DisplayMessage(string text, string prefix = Mission, Color? color = nil)</strong></td><td>Display a text message to the player.</td></tr>

@pchote pchote added this to the Next Release milestone Feb 28, 2021
@pchote
Copy link
Member Author

pchote commented Mar 9, 2021

Ping for a second review.

@teinarss teinarss merged commit a6467cb into OpenRA:bleed Mar 10, 2021
@pchote pchote deleted the nullable-lua branch April 8, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullable parameters break Lua API documentation
3 participants