Fix possible endless loop in replay recorder while opening save file. #19209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchote
reviewed
Mar 13, 2021
| catch (IOException) { } | ||
| catch (IOException ex) | ||
| { | ||
| if (id > 128) |
There was a problem hiding this comment.
Can you please add a comment explaining the significance of 128? We know right now that this is arbitrary, but looking back at this in 5 years might cause confusion over whether 128 is meaningfully different than 100 or 500.
There was a problem hiding this comment.
Better to have it as a constant with a good name?
There was a problem hiding this comment.
Sure, but that should still have a comment explaining the motivation for its specific value (unless we want to call it const int ArbitraryRetryCount 😁 - but please don't call it that)
anvilvapre
force-pushed
the
20210302_replay_recorder_fix_18789
branch
from
930cc42
to
bf92678
Compare
reaperrr
approved these changes
Apr 10, 2021
teinarss
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18789.
Minimal fix. To be able to close the issue. Should not occur in practice.
Throws an
ArgumentExceptionbecause the normal situation the filename contains a timestamp. If a file can not be created after 128+ attempt is likely indicates the filename refers to an invalid - non writable - path.