Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readonly to structs #19223

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Add readonly to structs #19223

merged 1 commit into from
Mar 14, 2021

Conversation

teinarss
Copy link
Contributor

@teinarss teinarss commented Mar 8, 2021

No description provided.

anvilvapre
anvilvapre reviewed Mar 12, 2021
View reviewed changes
OpenRA.Game/WPos.cs Outdated Show resolved Hide resolved
@anvilvapre
Copy link
Contributor

CellLayer Index[CPos] could benefit from 'in'. Used in many critical parts.

@teinarss
Copy link
Contributor Author

CellLayer Index[CPos] could benefit from 'in'. Used in many critical parts.

@anvilvapre It is only beneficial to add the in modifier to structs that are larger than intptr

@teinarss
Copy link
Contributor Author

Updated.

@abcdefg30 abcdefg30 merged commit 6b74093 into OpenRA:bleed Mar 14, 2021
@abcdefg30
Copy link
Member

Changelog

@teinarss teinarss deleted the readonly_structs branch April 15, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvilvapre anvilvapre anvilvapre left review comments

@pchote pchote pchote approved these changes

@abcdefg30 abcdefg30 abcdefg30 approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teinarss @anvilvapre @abcdefg30 @pchote