Add custom map pool support for dedicated servers #19323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @ubitux |
|
Now needs a rebase/update for #19239. |
This takes a list of map UIDs which may be locally installed or hosted on the resource center. If any maps aren't found, startup will be delayed by up to 10 seconds while it attempts to query the resource center.
Maps that aren't installed are queried from the resource center.
|
Rebased. |
|
I no longer have the stomach to champion this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two big usability improvements for the ladder and similarly focused servers.
The first (for server hosts) is a new
Server.MapPoolsetting to limit the maps that are allowed to be used on the server without resorting to modifying the local files and disabling RC queries. This setting takes a comma separated list of map UIDs, which may either be local maps or queried from the RC.The second (for players) is that the map browser on these servers will now show the map pool, including maps that aren't installed (again, queried from the RC). This removes any confusion about "Map was not found on server" errors, and allows players to install maps directly ingame instead of having to deal with manually installing map packs.
Depends on #19317.Depends on #19322.I think that with this PR we now also implement enough to close #3357. There are too many UI issues around searching and filtering the RC content to realistically support a full ingame browser, so relying on server hosts to curate map packs that players are able to download ingame strikes a good compromise.