Fix Move regression #19349
Merged
Fix Move regression #19349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't appear to be sufficient to solve the issue, or maybe i'm doing something silly. Testcase:
The Medium Tank surges ahead with noticable jerks showing that it is still double-ticking. |
|
Updated. Fingers crossed, but I think I got it. Passes the above testcase now, at least. Changed the approach to tracking the world tick we're on, which I believe makes for cleaner and easier-to-understand code, too. |
|
Good idea. I think we might now be able to remove the |
|
Updated, but put the changes in a separate commit for now. |
pchote
reviewed
May 16, 2021
|
LGTM otherwise and I didn't see any problems with a quick test ingame after making the above change. So 👍 after addressing that and squashing. |
If progress == Distance, we must not move again on the same tick, but still 'return true' to avoid losing a tick in the case when this is the last Move tick followed by a different activity (or a new queued Move, for example via waypoints).
|
Updated. |
pchote
approved these changes
May 16, 2021
teinarss
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
progress == Distance, we must not move again on the same tick, but stillreturn trueto avoid losing a tick in the casewhen this is the last
Movetick followed by a different activity (or a new queuedMove, for example via waypoints).Fixes #19347.