Split RA expansion mission categories #19350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proper title conventions in English typically have articles (if, and, the, of, to) lower-case unless they lead the title. I checked Remastered and they have the titles like this. That said, they aren't entirely consistent either with one or two capitalized articles. |
Smittytron
reviewed
Apr 17, 2021
It's not always apparent from the title which faction a mission belongs to, and players may want to know beforehand instead of having to guess.
reaperrr
force-pushed
the
split-campaign-categs
branch
from
8899713
to
b1122f3
Compare
Updated, dropped that commit for now. Might update and refile as dedicated PR later. |
Smittytron
approved these changes
Apr 24, 2021
There was a problem hiding this comment.
@reaperrr I can tackle the title casing in my next misc mission improvement PR if that's fine by you.
pchote
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always apparent from the title which faction an expansion mission belongs to, and players may want to know beforehand instead of having to guess.
Also made all title words start uppercase for consistency.