Cleanup in OrderManager #19359
Merged
Cleanup in OrderManager #19359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teinarss
force-pushed
the
ref_ordermanager
branch
from
a4c3729
to
e4b4578
Compare
|
@pchote Before I merge this, anything in here you disagree with? |
|
This is a good idea but I don't have any time spare to think about the implications of the specific changes. Lets take it, can always revert or fix it if regressions are found during playtesting. |
reaperrr
approved these changes
Jun 12, 2021
Too soon? #19448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some properties that did not belong to the OrderManager. Had to put these on a static class unfortunate, the other option is to have them on the Game class, but that class is already a monster. Hopefully i can find a proper place for them in a future refactoring.