Updated TD unit speeds to account for move jumpy-ness fix. #19371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix for #19347 has justs been merged, so can we please rebase this now on latest bleed? |
darkademic
force-pushed
the
updated-td-unit-speeds
branch
from
264624f
to
b18e664
Compare
|
If the 127 speed vehicles are supposed to be 128 #19347 is now fixed. |
darkademic
force-pushed
the
updated-td-unit-speeds
branch
from
b18e664
to
d219577
Compare
darkademic
force-pushed
the
updated-td-unit-speeds
branch
from
d219577
to
54531d4
Compare
Smittytron
approved these changes
May 30, 2021
reaperrr
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from: #19348
The recently merged #19220 causes the speeds of all non-aircraft units to change.
This adjusts all of the TD unit speeds so that their in-game movement is the same as it was prior to the fix.
It has been pointed out that there'll also be differences when units are turning while moving which can't be as straightforwardly tested, so this should just serve as the starting point for more fine tuning.
In addition I've adjusted all the locomotors to have 100% movement on clear terrain, as this makes for easier comparison between units using different locomotors - given that most time is spent on clear terrain. There may be some very minor differences due to rounding for the other terrain types, but it should be close enough to not be noticeable/impactful.
Video of before and after side by side: https://www.youtube.com/watch?v=QyTt-eBmO_Y