New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified debug slash command names #19414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm that aside. It might be worth moving those out to string constants to avoid such errors.
IMO adding a bunch of string constants that are each only used twice isn't a great solution for those files. A better approach would be to define a dictionary of name → (desc, handler) similar to how we do in This brings the same benefits but with significantly less boilerplate. |
Updated as suggested. |
Reorganize dev cheat command handling.
I use the debug chat commands a lot and what annoys me when using tab completion is that they all start with the same redundant word like
/show
or/debug
so there is a high chance it picks the wrong one. This renames all of them to the clear and concise style of #11544 as/exits-overlay
makes it clear what it is about and the dash between the nouns helps with readability. It doesn't change them too much so hopefully, so muscle memory stays mostly intact.