Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in OrderManager #19422

Merged
merged 1 commit into from
May 23, 2021
Merged

Fix crash in OrderManager #19422

merged 1 commit into from
May 23, 2021

Conversation

teinarss
Copy link
Contributor

Fixes #19415

Supersedes: #19416

pchote
pchote reviewed May 21, 2021
View reviewed changes
OpenRA.Game/Network/OrderManager.cs Outdated Show resolved Hide resolved
OpenRA.Game/Network/OrderManager.cs Outdated Show resolved Hide resolved
@teinarss
Copy link
Contributor Author

It was possible to make it even simpler by removing activeClients

@teinarss
Copy link
Contributor Author

Updated.

@teinarss
Copy link
Contributor Author

Fixed.

@pchote
Copy link
Member

pchote commented May 22, 2021

LGTM after fixing the TryGetValue and adding the extra disposed check.

@teinarss
Copy link
Contributor Author

Fixed.

@teinarss
Copy link
Contributor Author

Updated.

Mailaender
Mailaender approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@Mailaender Mailaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the shellmap and network play work on @OpenHV for commit 037e1ff.

@pchote pchote merged commit d10c592 into OpenRA:bleed May 23, 2021
@pchote pchote mentioned this pull request May 23, 2021
Closed
@pchote
Copy link
Member

pchote commented May 23, 2021

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/ab1b72e948a1043a5ff56029a9084f285139a6a9

@pchote pchote mentioned this pull request May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr left review comments

@pchote pchote pchote approved these changes

@Mailaender Mailaender Mailaender approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attempted to process orders from client X for frame 1 on frame X
4 participants
@teinarss @pchote @Mailaender @reaperrr