OrderIO performance improvement #19425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrderIO, ToOrderList, skip if frame is empty, which occurs often each client each frame.
pchote
approved these changes
May 22, 2021
|
Another solution would be to make the method return a ienumerable<> and
then use enumerable.empty
…On Sun, 23 May 2021, 00:27 Paul Chote, ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19425 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESI7GH3IBF4OJRFLTPVO6LTPAVTZANCNFSM45K3SI7Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderIO.ToOrderList: Skip if frame is empty, which occurs often each client each frame.
Split the part that should be uncontroversial and not conflict with other PRs from #19011.
According to my own measuring, negligible but consistent gains of about 20 stopwatch ticks per tick in singleplayer/shellmap. Not much, but better than nothing.